fastfetch icon indicating copy to clipboard operation
fastfetch copied to clipboard

TerminalShell (Linux): better support for Ghostty

Open apocelipes opened this issue 5 months ago • 2 comments

Changes:

  • Remove the suffix from the Ghostty version string on Arch Linux, which is not present in other distributions or macOS.

Ghostty does not support Windows (still WIP at an early stage), so only *nix parts modified.

apocelipes avatar Jun 12 '25 10:06 apocelipes

Ubuntu: ubuntu ubuntu2

Arch Linux: archlinux1 archlinux2

apocelipes avatar Jun 14 '25 20:06 apocelipes

Rebased. Commit message has been updated.

apocelipes avatar Jun 17 '25 09:06 apocelipes

Hello. Please reply my comments first.

CarterLi avatar Jun 23 '25 10:06 CarterLi

Hello. Please reply my comments first.

I'm sorry, I didn't see it, could you quote-reply the comment and @ me?

I only saw this and replied: image

apocelipes avatar Jun 23 '25 10:06 apocelipes

Hello. Please reply my comments first.

I'm sorry, I didn't see it, could you quote-reply the comment and @ me?

I only saw this and replied: image

@CarterLi

apocelipes avatar Jun 23 '25 12:06 apocelipes

@CarterLi So, where is your comment? Could you paste a screenshot like what I did?

apocelipes avatar Jun 24 '25 11:06 apocelipes

Can you see it now?

CarterLi avatar Jun 24 '25 12:06 CarterLi

Can you see it now?

Thanks, I can see it now. Maybe it's Github's bug that it didn't display to me.

apocelipes avatar Jun 24 '25 13:06 apocelipes

The version suffix doesn't indicate a change in the program code, sometimes the suffix changes simply by packager recompiling it. Many other programs don't have the suffix in their versions output, such as bash (usually this is a side effect of the formatting), so I'm considering whether or not to remove ghostty's version suffix just the same.

But since Fedora also has a version suffix, I think it's okay to keep it.

I'll close this PR. Thanks for your review.

apocelipes avatar Jun 24 '25 13:06 apocelipes