fastfetch
fastfetch copied to clipboard
fastfetch-cli
prioritize lscpu model output for arm linux systems if available
resolves https://github.com/fastfetch-cli/fastfetch/issues/567#issuecomment-2183677298
It's not fallback. It's force.
lscpu should always used as fallback, because you cant assume it's available.
It's not fallback. It's force.
lscpu should always used as fallback, because you cant assume it's available.
corrected name.
feel free to rework so that the lscpu section is called first so that it takes priority rather than forcing it.
@CarterLi how about something like that ^ Now lscpu is only prioritized and will fallback to /proc/cpuinfo if lscpu is not available
I dont like the idea. The CPU name was reported by Linux kernel. If you think it is wrong, it is a kernel issue.
I dont like the idea. The CPU name was reported by Linux kernel. If you think it is wrong, it is a kernel issue.
same deal with apple silicon which you have codepaths for. this is just how ARM cpu's have always been represented (with their implementer, architecture, variant, and part numbers) with no "pretty" model name
https://github.com/util-linux/util-linux/blob/master/sys-utils/lscpu-arm.c
also with this you can remove the hacky asahi codepaths and leave that to lscpu.
https://github.com/util-linux/util-linux/commit/744d62ee0c54963539832ec5943f3d25e0fccfbd
so yeah sorry not going to happen. just use lscpu like everyone else. it does not add any measurable execution time (yes I have checked)
It is either that or you just effectively copy/paste the entirety of lscpu arm decode code into fastfetch and maintain it independently which I don't see as any better.