fastapi
fastapi copied to clipboard
🌐 Start translations to Tamil, with first translation for `docs/ta/docs/index.md`
#5434
In this PR, I initialized tamil translation directory and adding translations for index.md file.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
cf73051) 100.00% compared to head (cb7edef) 100.00%. Report is 1242 commits behind head on master.
:exclamation: Current head cb7edef differs from pull request most recent head a1cb118. Consider uploading reports for the commit a1cb118 to get more accurate results
Additional details and impacted files
@@ Coverage Diff @@
## master #5500 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 540 540
Lines 13969 13946 -23
=========================================
- Hits 13969 13946 -23
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
📝 Docs preview for commit d5f7eb7764a2a8cd5bd23267288422d7324aff78 at: https://634bcb7faa66ac573ff79a9f--fastapi.netlify.app
📝 Docs preview for commit 7f84dd67e822bd25b3743c2e2d64f354f9945c25 at: https://635d298d1f721657773f164a--fastapi.netlify.app
📝 Docs preview for commit 8d65cbc0d2fa5e90a23fb1534a5c7d221a433990 at: https://635ff1065b1bfe660b52985d--fastapi.netlify.app
Awesome, thank you! :rocket:
And thanks for creating the issue to coordinate translations, I just added it here for Tamil: https://github.com/tiangolo/fastapi/issues/1497
~It might be a good idea to make a PR with just the setup, just the files, without the translation, I can approve and merge that right away. And then you can create another PR adding just the translation. That one will take longer because it needs at least 2 people that understand the language to approve it.~
I just updated the setup for translations and now is a one-line config file, I just updated it here.
And thanks for creating the issue to coordinate translations, I just added it here for Tamil: #1497
Thank you!
It might be a good idea to make a PR with just the setup, just the files, without the translation
Added setup in #5564
In my opinion, this is a great translation. But there are no words for programming code, computer terminal in tamil, which has been translated with different context here.
For example, Programming code has been translated as "குறியீடு", which is actually is the word for symbols.
Same with terminal - முனையம், which is a airport terminal.
This translation will create confusion for people who try to read for first time, which contradict the simplicity of original documentation and misleads with different contexts in many places.
My suggestion would be using English words directly where there is no tamil word available.
@tiangolo @Elcomerz @gusty1g
Thanks @FluffyDietEngine! Yep, that makes sense to me. Not sure how easy it is to mix English and how strange would it look for people, but I would do that (for example, I would do it in Spanish, use English words for things that don't have an obvious Spanish version).
Sounds reasonable, I will update the PR by using english words for some technical terms.
📝 Docs preview for commit bfc27b94263dfc3dcea79406a9e01cd953fc2f7e at: https://649a23497ba225195de3ab29--fastapi.netlify.app
📝 Docs preview for commit 564d9b48074d1fe02321243e5a6d6d806742d71c at: https://649a2afeec68df1d46e6b311--fastapi.netlify.app
Thanks for the interest @arunppsg 🥳
Do you think this one is ready to be merged now with the suggested changes applied? @Elcomerz @FluffyDietEngine 🤔
@alejsdev I believe still the problem exists in many places. Would not recommend to merge the PR.
As this PR had requested changes to be applied but has been inactive for a while, it's now going to be closed. But if there's anyone interested, feel free to create a new PR.