nbdev icon indicating copy to clipboard operation
nbdev copied to clipboard

Published 20 hours ago • verified publisher icon fastai

ADD example.ipynb and associated images to provide docs for V2

Open n-e-w opened this issue 3 years ago • 6 comments

References the new nbdev_cards examples / repo. Fixes #729

n-e-w avatar Aug 09 '22 03:08 n-e-w

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

review-notebook-app[bot] avatar Aug 09 '22 03:08 review-notebook-app[bot]

Great job Nick! Just some small nits and its ready to go!

hamelsmu avatar Aug 09 '22 07:08 hamelsmu

I made some small corrections, you might want to pull if you want to keep working on this.

hamelsmu avatar Aug 09 '22 07:08 hamelsmu

Will do! Leave it with me.

n-e-w avatar Aug 09 '22 08:08 n-e-w

@n-e-w how are you getting along? need any help?

jph00 avatar Aug 12 '22 20:08 jph00

I'm going to add the updated images this weekend.

n-e-w avatar Aug 13 '22 01:08 n-e-w

Should I close this?

hamelsmu avatar Jan 20 '23 19:01 hamelsmu

Yeh, I think we agreed it was outdated at the time -- I'm happy to rewrite to something reflecting latest updates though?

n-e-w avatar Jan 25 '23 03:01 n-e-w

OK closing this.

jph00 avatar Jan 26 '23 00:01 jph00