rules icon indicating copy to clipboard operation
rules copied to clipboard

vote: Adding @darryk10 to rules approvers

Open darryk10 opened this issue 1 year ago • 9 comments

What type of PR is this? After more than a year as a reviewer in the falcosecurity/rules repo and more than 3 years as a contributor in the Falco community, I want to propose myself as a rule approver.

Uncomment one (or more) /kind <> lines:

/kind feature

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area rules

/area registry

/area build

/area documentation

Proposed rule maturity level

Uncomment one (or more) /area <> lines (only for PRs that add or modify rules):

/area maturity-stable

/area maturity-incubating

/area maturity-sandbox

/area maturity-deprecated

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

darryk10 avatar May 20 '24 14:05 darryk10

Big +1 from me!

/hold until we reach the majority or a week has passed

cc @falcosecurity/rules-maintainers

leogr avatar May 20 '24 15:05 leogr

+1 , thank you @darryk10 !

LucaGuerra avatar May 20 '24 15:05 LucaGuerra

PS this PR triggered a bug in the CI that validates rules. I will dig into it. It's unrelated to this PR, so please ignore it.

leogr avatar May 20 '24 15:05 leogr

LGTM label has been added.

Git tree hash: 12a4ec6a0bd814c4114af74d1b626007e119303b

poiana avatar May 20 '24 15:05 poiana

Big +1 from me!

Andreagit97 avatar May 20 '24 16:05 Andreagit97

Big +1 great pleasure to welcome you as approver ❤️

incertum avatar May 20 '24 16:05 incertum

+1 from me! Welcome!!

FedeDP avatar May 20 '24 20:05 FedeDP

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: darryk10, Kaizhe, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

poiana avatar May 29 '24 14:05 poiana

LGTM label has been added.

Git tree hash: b30d8cb409ada1fc977f8bf0ca95768acc9c3a31

poiana avatar May 29 '24 14:05 poiana