libs
libs copied to clipboard
falcosecurity
update(cmake): Use TARGETS to install our libraries.
Use "install(TARGETS ..." instead of "install(FILES ..." to install libsinsp and libscap. This is compatible with multi-config generators such as Visual Studio. It also gives us control over where different types of artifacts are installed.
Signed-off-by: Gerald Combs [email protected]
What type of PR is this?
Uncomment one (or more)
/kind <>lines:
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
Any specific area of the project related to this PR?
Uncomment one (or more)
/area <>lines:
/area API-version
/area build
/area CI
/area driver-kmod
/area driver-bpf
/area driver-modern-bpf
/area libscap-engine-bpf
/area libscap-engine-gvisor
/area libscap-engine-kmod
/area libscap-engine-modern-bpf
/area libscap-engine-nodriver
/area libscap-engine-noop
/area libscap-engine-source-plugin
/area libscap-engine-savefile
/area libscap-engine-udig
/area libscap
/area libpman
/area libsinsp
/area tests
/area proposals
Does this PR require a change in the driver versions?
/version driver-API-version-major
/version driver-API-version-minor
/version driver-API-version-patch
/version driver-SCHEMA-version-major
/version driver-SCHEMA-version-minor
/version driver-SCHEMA-version-patch
What this PR does / why we need it:
This fixes the "install" targets when using multi-config generators. Tested with Visual Studio, but should work with Xcode and Ninja Multi-Config.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
NONE
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: geraldcombs
Once this PR has been reviewed and has the lgtm label, please assign lucaguerra for approval by writing /assign @lucaguerra in a comment. For more information see:The Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Is LIBRARY and RUNTIME there for completeness or does it actually install shared libs/binaries?
They're there for completeness. RUNTIME in particular ensures that DLLs will be installed in the right place if we ever enable shared libraries.
I don't think we will make it for the 0.10.0. Moving to 0.11.0. /milestone 0.11.0
Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/falcosecurity/community.
/lifecycle stale