libs
libs copied to clipboard
falcosecurity
wip: fix(userspace/libsinsp): actually immediately add synchronously spotted containers to list of containers
Signed-off-by: Federico Di Pierro [email protected]
What type of PR is this?
Uncomment one (or more)
/kind <>lines:
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
Any specific area of the project related to this PR?
Uncomment one (or more)
/area <>lines:
/area build
/area driver-kmod
/area driver-ebpf
/area libscap
/area libsinsp
/area tests
/area proposals
What this PR does / why we need it: This PR addresses a behavioral change that happened in #231 : before, synchronous container engines were seeing their containers immediately stored in the list, therefore their info was suddenly available. After, everything was async, pushing a container event and awaiting for the parser logic to add the new container.
This PR reverts to old behavior with a small plus: it adds immediately containers from async container engines (cri/docker/podman) when the informations are actually synchronously retrieved.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
NONE
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: FedeDP
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [FedeDP]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Possibly #364 supplants this one; i am leaving this opened to let maintainers choose the best approach.
IMO, i quite like this one because it is future proof and does not require each engine doing things (that, read right now might makes sense, but read a month from now, will be weird: "why are some engines calling add_container and others not?")
Moreover, i find this one rather self explanatory.
I know that @gnosek prefers to keep it simple, and go with #364 though :)
Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/falcosecurity/community.
/lifecycle stale
@FedeDP: Closed this PR.
In response to this:
/close
We won't implement this one.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.