libs
libs copied to clipboard
falcosecurity
Make installing files during install configurable
Some users of libs use its cmake files directly via an include() directive. By doing that, those users inherit any install() directives in the libs CMakeFiles.
Prior to the changes in https://github.com/falcosecurity/libs/pull/247, libs did not actually have any install() directives, but now that it does, the users of libs end up getting libsinsp/libscap as well as all of its dependencies installed as well, which may not be what they want.
To allow for both use cases, have install()s controlled by an option INSTALL_LIBS, which defaults to ON. Any users of libs that want to use the cmake files and that don't want anything installed can set this option to OFF.
Signed-off-by: Mark Stemm [email protected]
What type of PR is this?
Uncomment one (or more)
/kind <>lines:
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
Any specific area of the project related to this PR?
Uncomment one (or more)
/area <>lines:
/area build
/area driver-kmod
/area driver-ebpf
/area libscap
/area libsinsp
/area tests
/area proposals
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
build: make installation optional, controlled by an option `INSTALL_LIBS` (defaults to ON)
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: mstemm
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [mstemm]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
I wished there was a more elegant way to achieve this though :(
A falco_install (or other name) macro? It will require several include though...
Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/falcosecurity/community.
/lifecycle stale
Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/falcosecurity/community.
/lifecycle rotten
Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.
Provide feedback via https://github.com/falcosecurity/community. /close
@poiana: Closed this PR.
In response to this:
Rotten issues close after 30d of inactivity.
Reopen the issue with
/reopen.Mark the issue as fresh with
/remove-lifecycle rotten.Provide feedback via https://github.com/falcosecurity/community. /close
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.