libs icon indicating copy to clipboard operation
libs copied to clipboard

wip: fix(driver): fix build of kmod on linux 6.10.

Open FedeDP opened this issue 1 year ago • 8 comments

What type of PR is this?

/kind bug

Any specific area of the project related to this PR?

/area driver-kmod

Does this PR require a change in the driver versions?

What this PR does / why we need it:

https://github.com/torvalds/linux/commit/c4aab26253cd1f302279b8d6b5b66ccf1b120520, included in linux 6.10-rc1, moved fd_is_open away from an header we can include. Therefore the proposed patch is to implement ourself the one-liner.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Keeping it as wip until linux 6.10 is nearly released. I'll use this PR for tests if more changes are needed.

Does this PR introduce a user-facing change?:

fix(driver): fix build of kmod on linux 6.10.

FedeDP avatar May 30 '24 09:05 FedeDP

/milestone next-driver

FedeDP avatar May 30 '24 09:05 FedeDP

Kmod build is now ok: https://github.com/falcosecurity/libs/actions/runs/9300407315/job/25596333511

FedeDP avatar May 30 '24 09:05 FedeDP

LGTM! I would just add the kernel commit link also in the code not just in the PR

Andreagit97 avatar Jun 03 '24 08:06 Andreagit97

Done, anyway, let's wait for at least 6.10-rc6 before unholding :)

FedeDP avatar Jun 03 '24 08:06 FedeDP

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, FedeDP, LucaGuerra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

poiana avatar Jun 04 '24 08:06 poiana

RC3: still ok: https://github.com/falcosecurity/libs/actions/runs/9544785509/job/26304199255

FedeDP avatar Jun 17 '24 08:06 FedeDP

Hey @FedeDP

What's missing here? :thinking:

leogr avatar Jun 25 '24 15:06 leogr

RC5 still ok: https://github.com/falcosecurity/libs/actions/runs/9675438479/job/26692952935

FedeDP avatar Jun 26 '24 07:06 FedeDP

Green against rc7: https://github.com/falcosecurity/libs/actions/runs/9869833752/job/27254326144 Removing wip and merging.

FedeDP avatar Jul 10 '24 07:07 FedeDP

/milestone 7.2.1+driver

FedeDP avatar Aug 01 '24 08:08 FedeDP