libs icon indicating copy to clipboard operation
libs copied to clipboard

Use config check to enable memfd related processing

Open lrishi opened this issue 1 year ago • 2 comments

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area API-version

/area build

/area CI

/area driver-kmod

/area driver-bpf

/area driver-modern-bpf

/area libscap-engine-bpf

/area libscap-engine-gvisor

/area libscap-engine-kmod

/area libscap-engine-modern-bpf

/area libscap-engine-nodriver

/area libscap-engine-noop

/area libscap-engine-source-plugin

/area libscap-engine-savefile

/area libscap

/area libpman

/area libsinsp

/area tests

/area proposals

Does this PR require a change in the driver versions?

/version driver-API-version-major

/version driver-API-version-minor

/version driver-API-version-patch

/version driver-SCHEMA-version-major

/version driver-SCHEMA-version-minor

/version driver-SCHEMA-version-patch

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Currently, memfd exe flag is set for kernel versions > 3.17. However, some earlier kernels backport memfd support. This PR introduces a better check using CONFIG_MEMFD_CREATE to run the required logic in kmod.

lrishi avatar Apr 30 '24 18:04 lrishi

Please double check driver/SCHEMA_VERSION file. See versioning.

/hold

github-actions[bot] avatar Apr 30 '24 18:04 github-actions[bot]

LGTM label has been added.

Git tree hash: fe3e773889d0aa2e31627a5419144c6b9ac04a21

poiana avatar May 02 '24 08:05 poiana

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, FedeDP, lrishi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

poiana avatar May 02 '24 09:05 poiana

/unhold

FedeDP avatar May 02 '24 09:05 FedeDP