libs icon indicating copy to clipboard operation
libs copied to clipboard

[TRACKING] Improve container engine state handling

Open incertum opened this issue 1 year ago • 7 comments

Motivation

We have identified a few areas of improvements wrt to state handling during the container lookup cycle, see https://github.com/falcosecurity/libs/pull/1595#discussion_r1502988032.

This issue serves to track progress in this regard.

It is also related to https://github.com/falcosecurity/libs/issues/291.

@gnosek @therealbobo @mstemm @leogr

incertum avatar Feb 26 '24 17:02 incertum

Please also explore https://github.com/falcosecurity/libs/pull/1707: It's incorrect to initialize a lookup to SUCCESSFUL, by the way. I believe this is the strongest indication of a very suboptimal shared design across the container engines we support.

incertum avatar Feb 26 '24 17:02 incertum

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

poiana avatar May 26 '24 21:05 poiana

/remove-lifecycle stale

Will get back to it soon.

incertum avatar May 27 '24 10:05 incertum

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

poiana avatar Aug 25 '24 16:08 poiana

/remove-lifecycle stale

leogr avatar Aug 27 '24 14:08 leogr

We didn't get to this for libs 0.18. We need a lot more time to improve this as it will also need lots of testing.

We can try libs 0.19 or the following dev cycle.

incertum avatar Aug 27 '24 18:08 incertum

Agree! /milestone 0.19.0

FedeDP avatar Aug 27 '24 19:08 FedeDP

/milestone 0.20.0

FedeDP avatar Nov 13 '24 09:11 FedeDP

Considering https://github.com/falcosecurity/falco/issues/3403, i think we can close this one. (i mean, no big effort/refactor/cleanup will be made on that area of sinsp since we are moving away from it).

/close

(Feel free to reopen if you feel this is still valuable!)

FedeDP avatar Jan 03 '25 10:01 FedeDP

@FedeDP: Closing this issue.

In response to this:

Considering https://github.com/falcosecurity/falco/issues/3403, i think we can close this one. (i mean, no big effort/refactor/cleanup will be made on that area of sinsp since we are moving away from it).

/close

(Feel free to reopen if you feel this is still valuable!)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

poiana avatar Jan 03 '25 10:01 poiana