event-generator icon indicating copy to clipboard operation
event-generator copied to clipboard

adding an event for disallowed_ssh_connection_non_standard_port

Open h4l0gen opened this issue 1 year ago • 3 comments

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind documentation

/kind tests

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area commands

/area pkg

/area events

What this PR does / why we need it: this triggers rule disallowed ssh connection non standard port Which issue(s) this PR fixes:

Fixes #142

Special notes for your reviewer:

h4l0gen avatar Mar 19 '24 08:03 h4l0gen

TCP protocol condition is met by SSH connection, as SSH uses TCP protocol

h4l0gen avatar Mar 19 '24 08:03 h4l0gen

Hii @FedeDP @leogr this event triggered stable rule successfully image Please provide your feedback. Thank You!!

h4l0gen avatar Apr 04 '24 21:04 h4l0gen

LGTM label has been added.

Git tree hash: a20a55c5c4b96b8994af375195aa17a7415357fd

poiana avatar Apr 22 '24 11:04 poiana

@FedeDP I think branch protection rules interfered with merging this event :)

h4l0gen avatar Apr 22 '24 11:04 h4l0gen

@FedeDP I think branch protection rules interfered with merging this event :)

What do you mean?

FedeDP avatar Apr 22 '24 11:04 FedeDP

Can you squash this one into a single commit and rebase on top of main?

FedeDP avatar Apr 22 '24 11:04 FedeDP

@FedeDP please add LGTM label again. Sorry for the inconvenience :)

h4l0gen avatar Apr 22 '24 14:04 h4l0gen

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP, h4l0gen, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

poiana avatar Apr 23 '24 14:04 poiana

LGTM label has been added.

Git tree hash: a7f834693ed0cecfc5334dbb6daff584785ef6a5

poiana avatar Apr 23 '24 14:04 poiana