event-generator icon indicating copy to clipboard operation
event-generator copied to clipboard

adding an event on triggering rule `disallowed ssh connection`

Open h4l0gen opened this issue 1 year ago • 3 comments

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind documentation

/kind tests

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area commands

/area pkg

/area events

What this PR does / why we need it: we need to detect functionality of rule disallowed ssh connection Which issue(s) this PR fixes:

Fixes #129

Special notes for your reviewer:

h4l0gen avatar Mar 18 '24 06:03 h4l0gen

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: h4l0gen Once this PR has been reviewed and has the lgtm label, please assign leogr for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

poiana avatar Mar 18 '24 06:03 poiana

@leogr, as this rule is disabled by default, I enabled it here. On event execution, the rule is triggered successfully, as shown in the terminal output below. Screenshot from 2024-03-27 17-51-26

h4l0gen avatar Mar 27 '24 12:03 h4l0gen

@leogr @FedeDP I have used timeout tag to reset connection after 1 second to complete event. Please review it again. Thank You!!

h4l0gen avatar Apr 04 '24 20:04 h4l0gen

/assign @FedeDP

leogr avatar Apr 23 '24 14:04 leogr

LGTM label has been added.

Git tree hash: 0e27d3b86e3c0e1f9174f15818a7d3e486ff6e6c

poiana avatar May 08 '24 12:05 poiana

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP, h4l0gen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

poiana avatar May 08 '24 12:05 poiana