python-mimeparse icon indicating copy to clipboard operation
python-mimeparse copied to clipboard

cgi deprecation

Open rafalkrupinski opened this issue 1 year ago • 2 comments

Hi guys, python 3.13 is in beta now. Any chance to release a version with the dependency on cgi removed?

rafalkrupinski avatar May 12 '24 18:05 rafalkrupinski

Yes, we'll try to get out a new version before 3.13 is released.

vytas7 avatar May 12 '24 19:05 vytas7

is the plan to vendor the functions from the cgi module used like it was done in falcon?

CaselIT avatar May 13 '24 12:05 CaselIT

Seems like the function was already vendored in, https://github.com/falconry/python-mimeparse/blob/master/mimeparse.py#L27-L47

All it takes now is someone to bump the version and release..

gorilla-seb avatar Aug 23 '24 09:08 gorilla-seb

Hi @gorilla-seb, yes, we'll try to get out a release shortly.

Falcon had some checks in the CI to verify that we were vendoring the latest version, I will need to temporarily (or permanently if we decide to reimplement what we need) disable these checks for the impending release of this project.

vytas7 avatar Aug 23 '24 10:08 vytas7

Hi again @gorilla-seb & @rafalkrupinski! This issue is now closed, and I have released 2.0.0rc1 to PyPI.

Please take it for a spin with your projects:

pip install python-mimeparse==2.0.0rc1

Unless we run into any serious issues, I'll cut 2.0.0 stable later.

vytas7 avatar Aug 23 '24 12:08 vytas7

My tests pass with the RC.

I only use best_match

rafalkrupinski avatar Aug 23 '24 22:08 rafalkrupinski

Thanks for checking, @rafalkrupinski! I have now cut a stable release, python-mimeparse v2.0, so you can update your dependencies.

vytas7 avatar Aug 25 '24 13:08 vytas7

Looks to be working fine, many thanks @vytas7!

gorilla-seb avatar Aug 27 '24 12:08 gorilla-seb