faker
faker copied to clipboard
faker-ruby
LoremPixel is no longer available
https://github.com/faker-ruby/faker/blob/master/lib/faker/default/lorem_pixel.rb
just FYI
HI @saiqulhaq could you please provide more information about this issue? I am not sure I understand what is the problem and what is your proposal. Thanks!
I can access LoremFlickr normally. Could you try again on your side? What exactly is the error you're getting when running Faker? Thanks!
Yeah, makes sense to delete it since it's not up anymore: https://github.com/faker-ruby/faker/blob/15a8bc35f489b2d5e06439c664363c779b125d6c/lib/faker/default/lorem_pixel.rb#L61
oh, okay, it makes more sense now. It looks like Lorem Pixel is now Lorem Ipsum.
At first glance, LoremPixel seems to be used only here. Could we use LoremFlickr instead to get rid of LoremPixel (and subsequent TODOs in that file)?
Hey folks, would it be okay if I started working on this one?
yes, thank you! 👏
I believe we need to add a deprecation warning before following along with this removal. I am going to update the issue with the steps needed for this.
thank you @uzorjchibuzor the first two tasks could be done in two initial PRs.
@stefannibrasil I'll make sure to mention you in the PRs. So this issue can remain open until all the tasks are done.
Add Tests for LoremFlickr on test_lorem_flickr.rb
@stefannibrasil I am not sure I understand this part, shouldn't this say that I should add a test on lorem_pixel instead that when is it called to refer to the lorem_flickr?
Also, all of the previous assertions on test_lorem_flickr are not relevant anymore as calls to that class are forwarded to LoremFlickr. What I am asking is that, after I test for the referral, is there anything more to add?
Hi @uzorjchibuzor I left a code review on your PR, thank you! About the tests, you're right. LoremFlickr already has tests. I removed this step from the issue.
The merged PR fixes the first step of this issue. Reopening to complete the remaining steps.
@uzorjchibuzor I updated the issue to reflect the next steps. The next one, to replace LoremPixel with LoremFlickr on faker, can be started anytime. Let me know if you have any questions. Thank you!
Hi there!
I saw the last free step, I just opened a PR to try complete this issue. Please fill free to review the last one.
hi @italopires thank you for your interest in contributing to Faker! This issue is already assigned to @uzorjchibuzor. We were just waiting on the deprecation message date to arrive to complete the work.
@uzorjchibuzor We can move on with this issue because December is here 🎄 Do you want to open a PR or contribute with @italopires ? I just want to make sure we are collaborating. Thank you, both!
Hi @stefannibrasil and @uzorjchibuzor, my apologies. It was my first attempt to contribute open source. I will close the PR and try another issue, in case you need it, I can reopen. Thank you very much!!
I will take care of this today. Sorry for the delay. I had to clear some backlog.
On Tue, 20 Dec 2022 at 5:26 AM, Stefanni Brasil @.***> wrote:
@uzorjchibuzor https://github.com/uzorjchibuzor are you still interested in finishing the issue?
— Reply to this email directly, view it on GitHub https://github.com/faker-ruby/faker/issues/2505#issuecomment-1358824890, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHZNEUXLT3WRBCOFSXJW523WOEYNZANCNFSM52QR5BLA . You are receiving this because you were mentioned.Message ID: @.***>
@uzorjchibuzor no worries! I didn't mean to rush you, I just wanted to know if you still had the bandwidth. Thank you!
I've just googled LoremPixel and it has indeed disappeared from the web. That was a good catch!
I tried to access the LoremFlickr website but my Avast is complaining..
Another alternative to LoremFlickr and LoremPixel would be Picsum:
- https://picsum.photos/
- https://picsum.photos/200/200
