velox icon indicating copy to clipboard operation
velox copied to clipboard

Add near zero-copy Import & Export for Arrow BinaryView/Utf8View formats

Open urvishdesai opened this issue 1 year ago • 6 comments
trafficstars

This change adds support for import/export of BinaryView and StringView from/to Arrow significantly boosting the performance of import and export of strings through the Arrow bridge.

Benchmark results show a gain of 4.3x (non-inline strings) - 18x (inline strings) faster for export and 2.2x (non-inline strings) - 7x (inline strings) faster for import of utf8view strings as compared to utf8 strings.

urvishdesai avatar May 06 '24 20:05 urvishdesai

Deploy Preview for meta-velox canceled.

Name Link
Latest commit 55d1ed5bf8bb45f19b90ca7f368589dc60cb3070
Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/66be7ddc1757320008148b84

netlify[bot] avatar May 06 '24 20:05 netlify[bot]

Hey @pedroerp , I work at ByteDance with @frankobe. Do you mind taking a look at this PR?

urvishdesai avatar May 09 '24 23:05 urvishdesai

@kgpai Looks like the build failed for one of the checks. Not sure if this was due to the change itself. I also see that Conbench performance report found 1 possible regression. Could you help me with these two issues?

urvishdesai avatar May 16 '24 23:05 urvishdesai

Not sure why the fuzzer job failed, I am re-running it. I am hoping to review this next week. I dont think we need to worry about the conbench results yet.

kgpai avatar May 16 '24 23:05 kgpai

@pedroerp I updated the PR

urvishdesai avatar May 30 '24 22:05 urvishdesai

Hi @kgpai and @pedroerp, kindly let me know when you get a chance to review the PR again. Thanks!

urvishdesai avatar Jun 10 '24 18:06 urvishdesai

@pedroerp following up on this! Please review my comments and code change again when you get a chance

urvishdesai avatar Jul 10 '24 18:07 urvishdesai

Please also rebase or merge in main to fix linux CI.

assignUser avatar Jul 24 '24 15:07 assignUser

@kgpai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar Aug 16 '24 16:08 facebook-github-bot

@kgpai merged this pull request in facebookincubator/velox@08dd2d486362974cbd42bcae89b8fdddbdaeb587.

facebook-github-bot avatar Aug 20 '24 21:08 facebook-github-bot

Conbench analyzed the 1 benchmark run on commit 08dd2d48.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

conbench-facebook[bot] avatar Aug 20 '24 22:08 conbench-facebook[bot]