velox
velox copied to clipboard
Add near zero-copy Import & Export for Arrow BinaryView/Utf8View formats
This change adds support for import/export of BinaryView and StringView from/to Arrow significantly boosting the performance of import and export of strings through the Arrow bridge.
Benchmark results show a gain of 4.3x (non-inline strings) - 18x (inline strings) faster for export and 2.2x (non-inline strings) - 7x (inline strings) faster for import of utf8view strings as compared to utf8 strings.
Deploy Preview for meta-velox canceled.
| Name | Link |
|---|---|
| Latest commit | 55d1ed5bf8bb45f19b90ca7f368589dc60cb3070 |
| Latest deploy log | https://app.netlify.com/sites/meta-velox/deploys/66be7ddc1757320008148b84 |
Hey @pedroerp , I work at ByteDance with @frankobe. Do you mind taking a look at this PR?
@kgpai Looks like the build failed for one of the checks. Not sure if this was due to the change itself. I also see that Conbench performance report found 1 possible regression. Could you help me with these two issues?
Not sure why the fuzzer job failed, I am re-running it. I am hoping to review this next week. I dont think we need to worry about the conbench results yet.
@pedroerp I updated the PR
Hi @kgpai and @pedroerp, kindly let me know when you get a chance to review the PR again. Thanks!
@pedroerp following up on this! Please review my comments and code change again when you get a chance
Please also rebase or merge in main to fix linux CI.
@kgpai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
@kgpai merged this pull request in facebookincubator/velox@08dd2d486362974cbd42bcae89b8fdddbdaeb587.
Conbench analyzed the 1 benchmark run on commit 08dd2d48.
There were no benchmark performance regressions. 🎉
The full Conbench report has more details.