velox icon indicating copy to clipboard operation
velox copied to clipboard

Published 20 hours ago • verified publisher icon facebookincubator

Remove global -Wno-Empty-Body compiler option

Open acvictor opened this issue 1 year ago • 4 comments
trafficstars

PR removes -Wno-Empty-Body which disables warnings if an empty body occurs in an if, else or do while statement. No warnings to fix.

Meant to address #9469

acvictor avatar Apr 17 '24 15:04 acvictor

Deploy Preview for meta-velox canceled.

Name Link
Latest commit b74b4b756bb8c62f05c587e00b0f697a1501c7a8
Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/663861f7f2c2d500083eabeb

netlify[bot] avatar Apr 17 '24 15:04 netlify[bot]

@pedroerp can you please review this PR? Thank you!

acvictor avatar Apr 17 '24 16:04 acvictor

Could you rebase? That should fix the CI error. Once CI is green +1

assignUser avatar May 06 '24 04:05 assignUser

@kgpai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar May 14 '24 17:05 facebook-github-bot

@kgpai merged this pull request in facebookincubator/velox@b470e85214f1adefa5b718c75c360e70f67ea8ce.

facebook-github-bot avatar May 15 '24 22:05 facebook-github-bot

Conbench analyzed the 1 benchmark run on commit b470e852.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

conbench-facebook[bot] avatar May 15 '24 23:05 conbench-facebook[bot]