velox icon indicating copy to clipboard operation
velox copied to clipboard

Published 20 hours ago • verified publisher icon facebookincubator

Add Presto inverse_laplace_cdf function

Open wills-feng opened this issue 1 year ago • 4 comments

Resolves https://github.com/facebookincubator/velox/issues/5541 This is a followup for https://github.com/facebookincubator/velox/pull/5543

wills-feng avatar Apr 15 '24 21:04 wills-feng

Deploy Preview for meta-velox canceled.

Name Link
Latest commit bf6340a150ff06c7fda0faa98075d9f278cb744d
Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/6692b0d1ee35e50008a63bc4

netlify[bot] avatar Apr 15 '24 21:04 netlify[bot]

@wills-feng : Please can you also give the fuzzer output for this function.

aditi-pandit avatar Apr 16 '24 20:04 aditi-pandit

@aditi-pandit I rewrote the function and tests. Also posted the fuzzer tests below, could you please help review, thanks.

I20240422 11:30:06.057255 28557681 ExpressionFuzzerVerifier.cpp:367] ==============================> Done with iteration 168281
I20240422 11:30:06.057325 28557681 ExpressionFuzzerVerifier.cpp:164] ==============================> Top 1 by number of rows processed
I20240422 11:30:06.057338 28557681 ExpressionFuzzerVerifier.cpp:166] Format: functionName numTimesSelected proportionOfTimesSelected numProcessedRows
I20240422 11:30:06.057350 28557681 ExpressionFuzzerVerifier.cpp:170] inverse_laplace_cdf 3813524 100.00% 3941527
I20240422 11:30:06.057366 28557681 ExpressionFuzzerVerifier.cpp:176] ==============================> Bottom 1 by number of rows processed
I20240422 11:30:06.057379 28557681 ExpressionFuzzerVerifier.cpp:178] Format: functionName numTimesSelected proportionOfTimesSelected numProcessedRows
I20240422 11:30:06.057392 28557681 ExpressionFuzzerVerifier.cpp:183] inverse_laplace_cdf 3813524 100.00% 3941527
I20240422 11:30:06.057405 28557681 ExpressionFuzzerVerifier.cpp:196] ==============================> All stats sorted by number of times the function was chosen
I20240422 11:30:06.057418 28557681 ExpressionFuzzerVerifier.cpp:198] Format: functionName numTimesSelected proportionOfTimesSelected numProcessedRows
I20240422 11:30:06.057430 28557681 ExpressionFuzzerVerifier.cpp:202] inverse_laplace_cdf 3813524 100.00% 3941527
E20240422 11:30:06.057442 28557681 ExpressionFuzzerVerifier.cpp:373] Total iterations: 168282
E20240422 11:30:06.057454 28557681 ExpressionFuzzerVerifier.cpp:374] Total failed: 10924
[==========] Running 0 tests from 0 test suites.
[==========] 0 tests from 0 test suites ran. (0 ms total)
[  PASSED  ] 0 tests.

wills-feng avatar Apr 22 '24 18:04 wills-feng

@kagamiori, @Yuhta, @kgpai : Please can you help with review and merge.

These are old PRs pending on Jimmy's fix in the Boost library.

aditi-pandit avatar Apr 23 '24 23:04 aditi-pandit

There are 3 probability functions PRs are waiting for merge. I have rebased https://github.com/facebookincubator/velox/pull/9492, once it gets merged, I will rebase this one.

wills-feng avatar Jul 08 '24 17:07 wills-feng

Once https://github.com/facebookincubator/velox/pull/9494 gets merged, I'll rebase this one.

wills-feng avatar Jul 10 '24 15:07 wills-feng

@wills-feng #9494 was merged.

pedroerp avatar Jul 11 '24 16:07 pedroerp

@pedroerp rebased and CI passed.

wills-feng avatar Jul 15 '24 19:07 wills-feng

@pedroerp has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar Jul 15 '24 19:07 facebook-github-bot

@pedroerp merged this pull request in facebookincubator/velox@0adc62e3aaf647596ab476f6300a4165e60f6b91.

facebook-github-bot avatar Jul 16 '24 01:07 facebook-github-bot

Conbench analyzed the 1 benchmark run on commit 0adc62e3.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

conbench-facebook[bot] avatar Jul 16 '24 01:07 conbench-facebook[bot]