velox icon indicating copy to clipboard operation
velox copied to clipboard

Add Presto function at_timezone

Open svm1 opened this issue 1 year ago • 6 comments
trafficstars

Implement at time zone feature from Presto Java, for TimestampWithTimezone input.

Example usage:

SELECT timestamp '2012-10-31 01:00 UTC' AT TIME ZONE 'America/Los_Angeles';
2012-10-30 18:00:00.000 America/Los_Angeles

svm1 avatar Jan 26 '24 03:01 svm1

Deploy Preview for meta-velox canceled.

Name Link
Latest commit 642b7f7489505359267449940a1f47b1d71442d9
Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/6647d8444cfe0900089db02c

netlify[bot] avatar Jan 26 '24 03:01 netlify[bot]

Rebased and modified to use new type implementation.

svm1 avatar Mar 05 '24 22:03 svm1

@pedroerp would appreciate if you could take a look!

svm1 avatar Apr 22 '24 20:04 svm1

@pedroerp has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar Apr 30 '24 04:04 facebook-github-bot

@svm1 looks like a bunch of builds are failing.

pedroerp avatar Apr 30 '24 22:04 pedroerp

Rebased as my branch was a bit out of date, should take care of the build issues.

svm1 avatar Apr 30 '24 23:04 svm1

@pedroerp no worries, thanks for all your feedback!

Fixed the build errors, had to update my initialize() method - and added docs as I realized I'd forgotten that.

svm1 avatar May 17 '24 23:05 svm1

@pedroerp has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar May 17 '24 23:05 facebook-github-bot

@pedroerp merged this pull request in facebookincubator/velox@8239bbdc67e05c9bd7430c127f958775dfb25405.

facebook-github-bot avatar May 20 '24 18:05 facebook-github-bot

Conbench analyzed the 1 benchmark run on commit 8239bbdc.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

conbench-facebook[bot] avatar May 20 '24 19:05 conbench-facebook[bot]