react icon indicating copy to clipboard operation
react copied to clipboard

[Fiber] clarify entry condition for suspensey commit recursion

Open gnoff opened this issue 1 year ago • 2 comments

Previously Suspensey recursion would only trigger if the ShouldSuspendCommit flag was true. However there is a dependence on the Visibility flag embedded in this logic because these flags share a bit. To make it clear that the semantics of Suspensey resources require considering both flags I've added it to the condition even though this extra or-ing is a noop when the bit is shared

gnoff avatar May 22 '24 19:05 gnoff

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 23, 2024 8:52pm

vercel[bot] avatar May 22 '24 19:05 vercel[bot]

Comparing: 3ac551e855f9bec3161da2fc8787958aa62113db...09f87eb35f5a739fbd28d5f3fafea2389b22d6a6

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.66 kB 6.66 kB +0.05% 1.82 kB 1.82 kB
oss-stable/react-dom/cjs/react-dom-client.production.js +0.02% 495.89 kB 496.01 kB +0.04% 88.82 kB 88.86 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.67 kB 6.67 kB +0.05% 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js +0.02% 500.69 kB 500.81 kB +0.04% 89.51 kB 89.54 kB
facebook-www/ReactDOM-prod.classic.js +0.02% 593.05 kB 593.16 kB +0.03% 104.32 kB 104.35 kB
facebook-www/ReactDOM-prod.modern.js +0.02% 569.27 kB 569.38 kB +0.04% 100.72 kB 100.76 kB
test_utils/ReactAllWarnings.js Deleted 64.35 kB 0.00 kB Deleted 16.05 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
test_utils/ReactAllWarnings.js Deleted 64.35 kB 0.00 kB Deleted 16.05 kB 0.00 kB

Generated by :no_entry_sign: dangerJS against 09f87eb35f5a739fbd28d5f3fafea2389b22d6a6

react-sizebot avatar May 22 '24 19:05 react-sizebot