react
react copied to clipboard
[react-dom] Remove `findDOMNode` from OSS builds
In the next major findDOMNode is being removed. This PR removes the API from the react-dom entrypoints for OSS builds and re-exposes the implementation as part of internals.
findDOMNode is being retained for Meta builds and so all tests that currently use it will continue to do so by accessing it from internals. Once the replacement API ships in an upcoming minor any tests that were using this API incidentally can be updated to use the new API and any tests asserting findDOMNode's behavior directly can stick around until we remove it entirely (once Meta has moved away from it)
Comparing: 8436bcca6287077a5409b3c9180f8af0361b16a5...9928ca53e4f173d571e34e4eca050df088919511
Critical size changes
Includes critical production bundles, as well as any change greater than 2%:
| Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |
|---|---|---|---|---|---|---|
| oss-stable/react-dom/cjs/react-dom.production.min.js | = | 176.92 kB | 176.93 kB | = | 54.99 kB | 54.99 kB |
| oss-experimental/react-dom/cjs/react-dom.production.min.js | = | 173.10 kB | 173.11 kB | +0.02% | 53.94 kB | 53.95 kB |
| facebook-www/ReactDOM-prod.classic.js | +0.01% | 592.31 kB | 592.39 kB | +0.02% | 103.83 kB | 103.85 kB |
| facebook-www/ReactDOM-prod.modern.js | +0.13% | 573.20 kB | 573.97 kB | +0.14% | 100.71 kB | 100.86 kB |
| test_utils/ReactAllWarnings.js | Deleted | 65.19 kB | 0.00 kB | Deleted | 16.30 kB | 0.00 kB |
Significant size changes
Includes any change greater than 0.2%:
Expand to show
Generated by :no_entry_sign: dangerJS against 9928ca53e4f173d571e34e4eca050df088919511