react icon indicating copy to clipboard operation
react copied to clipboard

[react-dom] Remove `findDOMNode` from OSS builds

Open gnoff opened this issue 1 year ago • 1 comments

In the next major findDOMNode is being removed. This PR removes the API from the react-dom entrypoints for OSS builds and re-exposes the implementation as part of internals.

findDOMNode is being retained for Meta builds and so all tests that currently use it will continue to do so by accessing it from internals. Once the replacement API ships in an upcoming minor any tests that were using this API incidentally can be updated to use the new API and any tests asserting findDOMNode's behavior directly can stick around until we remove it entirely (once Meta has moved away from it)

gnoff avatar Feb 07 '24 05:02 gnoff

Comparing: 8436bcca6287077a5409b3c9180f8af0361b16a5...9928ca53e4f173d571e34e4eca050df088919511

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 176.92 kB 176.93 kB = 54.99 kB 54.99 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 173.10 kB 173.11 kB +0.02% 53.94 kB 53.95 kB
facebook-www/ReactDOM-prod.classic.js +0.01% 592.31 kB 592.39 kB +0.02% 103.83 kB 103.85 kB
facebook-www/ReactDOM-prod.modern.js +0.13% 573.20 kB 573.97 kB +0.14% 100.71 kB 100.86 kB
test_utils/ReactAllWarnings.js Deleted 65.19 kB 0.00 kB Deleted 16.30 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-experimental/react-dom/cjs/react-dom.react-server.production.min.js +0.63% 2.69 kB 2.71 kB +1.15% 0.87 kB 0.88 kB
oss-stable-semver/react-dom/cjs/react-dom.react-server.production.min.js +0.63% 2.69 kB 2.71 kB +1.15% 0.87 kB 0.88 kB
oss-stable/react-dom/cjs/react-dom.react-server.production.min.js +0.63% 2.69 kB 2.71 kB +1.15% 0.87 kB 0.88 kB
oss-stable-semver/react-dom/cjs/react-dom-server-rendering-stub.production.min.js +0.47% 3.64 kB 3.66 kB +0.71% 1.27 kB 1.28 kB
oss-stable/react-dom/cjs/react-dom-server-rendering-stub.production.min.js +0.46% 3.67 kB 3.69 kB +0.70% 1.29 kB 1.30 kB
oss-experimental/react-dom/cjs/react-dom-server-rendering-stub.production.min.js +0.46% 3.68 kB 3.69 kB +0.78% 1.29 kB 1.30 kB
oss-stable-semver/react-dom/umd/react-dom-server-rendering-stub.production.min.js +0.45% 3.78 kB 3.80 kB +0.96% 1.36 kB 1.37 kB
oss-stable/react-dom/umd/react-dom-server-rendering-stub.production.min.js +0.45% 3.81 kB 3.82 kB +0.94% 1.38 kB 1.40 kB
oss-experimental/react-dom/umd/react-dom-server-rendering-stub.production.min.js +0.45% 3.81 kB 3.83 kB +1.01% 1.38 kB 1.40 kB
oss-experimental/react-dom/cjs/react-dom.react-server.production.js +0.33% 6.39 kB 6.41 kB +0.86% 1.29 kB 1.30 kB
oss-stable-semver/react-dom/cjs/react-dom.react-server.production.js +0.33% 6.39 kB 6.41 kB +0.86% 1.29 kB 1.30 kB
oss-stable/react-dom/cjs/react-dom.react-server.production.js +0.33% 6.39 kB 6.41 kB +0.86% 1.29 kB 1.30 kB
facebook-www/ReactDOM-dev.modern.js +0.24% 1,650.60 kB 1,654.53 kB +0.25% 328.33 kB 329.16 kB
facebook-www/ReactDOMTesting-dev.modern.js +0.24% 1,671.08 kB 1,675.01 kB +0.25% 332.76 kB 333.58 kB
oss-stable-semver/react-dom/cjs/react-dom-server-rendering-stub.production.js +0.23% 9.17 kB 9.19 kB +0.44% 2.29 kB 2.30 kB
oss-stable/react-dom/cjs/react-dom-server-rendering-stub.production.js +0.23% 9.20 kB 9.22 kB +0.43% 2.32 kB 2.33 kB
oss-experimental/react-dom/cjs/react-dom-server-rendering-stub.production.js +0.23% 9.20 kB 9.22 kB +0.43% 2.32 kB 2.33 kB
test_utils/ReactAllWarnings.js Deleted 65.19 kB 0.00 kB Deleted 16.30 kB 0.00 kB

Generated by :no_entry_sign: dangerJS against 9928ca53e4f173d571e34e4eca050df088919511

react-sizebot avatar Feb 07 '24 05:02 react-sizebot