react-native icon indicating copy to clipboard operation
react-native copied to clipboard

Define JSI bridging function for ShadowNode::Shared

Open rubennorte opened this issue 6 months ago • 6 comments

Summary: Changelog: [internal]

This defines a new bridging method to convert ShadowNode::Shared from and to JS. This has some benefits over the existing shadowNodeFromValue and valueFromShadowNode functions:

  1. It's more convenient, as we can just use ShadowNode::Shared in classes implementing the codegen, and the runtime will do the conversion automatically.
  2. It's safer, as it checks for nullability and throws JS exceptions except of having segmentation faults down the line.

Differential Revision: D75597542

rubennorte avatar May 29 '25 10:05 rubennorte

This pull request was exported from Phabricator. Differential Revision: D75597542

facebook-github-bot avatar May 29 '25 10:05 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D75597542

facebook-github-bot avatar May 29 '25 11:05 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D75597542

facebook-github-bot avatar May 29 '25 12:05 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D75597542

facebook-github-bot avatar May 29 '25 13:05 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D75597542

facebook-github-bot avatar May 29 '25 13:05 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D75597542

facebook-github-bot avatar May 29 '25 13:05 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D75597542

facebook-github-bot avatar May 29 '25 14:05 facebook-github-bot

This pull request has been merged in facebook/react-native@9c2148920c1c679f3ece295bc4614e9af7854a63.

facebook-github-bot avatar May 29 '25 18:05 facebook-github-bot

This pull request was successfully merged by @rubennorte in 9c2148920c1c679f3ece295bc4614e9af7854a63

When will my fix make it into a release? | How to file a pick request?

react-native-bot avatar May 29 '25 18:05 react-native-bot