facebook
Add E2E test for Console.log Measure and Interop Layer Measurements
This PR adds a new end-to-end test in new-arch-example.yml. It taps on the "Console.log Measure" button and verifies that the Interop Layer Measurements are correctly updated. Ensures the measurements are correctly reflected in the app's UI.
Hi @MobinAkhter!
Thank you for your pull request and welcome to our community.
Action Required
In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.
Process
In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.
Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.
If you have received this in error or have any questions, please contact us at [email protected]. Thanks!
| Fails | |
|---|---|
| :no_entry_sign: |
Danger failed to run |
| Warnings | |
|---|---|
| :warning: | :clipboard: Missing Summary - Can you add a Summary? To do so, add a "## Summary" section to your PR description. This is a good place to explain the motivation for making this change. |
| :warning: | :clipboard: Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested. |
Error ReferenceError
validateChangelog is not defined
ReferenceError: validateChangelog is not defined
at Object.<anonymous> (dangerfile.js:48:18)
at Module._compile (node:internal/modules/cjs/loader:1364:14)
at requireFromString (/home/runner/work/react-native/react-native/node_modules/require-from-string/index.js:28:4)
at /home/runner/work/react-native/react-native/node_modules/danger/distribution/runner/runners/inline.js:161:68
at step (/home/runner/work/react-native/react-native/node_modules/danger/distribution/runner/runners/inline.js:52:23)
at Object.next (/home/runner/work/react-native/react-native/node_modules/danger/distribution/runner/runners/inline.js:33:53)
at /home/runner/work/react-native/react-native/node_modules/danger/distribution/runner/runners/inline.js:27:71
at new Promise (<anonymous>)
at __awaiter (/home/runner/work/react-native/react-native/node_modules/danger/distribution/runner/runners/inline.js:23:12)
at runDangerfileEnvironment (/home/runner/work/react-native/react-native/node_modules/danger/distribution/runner/runners/inline.js:118:132)
at /home/runner/work/react-native/react-native/node_modules/danger/distribution/platforms/GitHub.js:181:38
at step (/home/runner/work/react-native/react-native/node_modules/danger/distribution/platforms/GitHub.js:44:23)
at Object.next (/home/runner/work/react-native/react-native/node_modules/danger/distribution/platforms/GitHub.js:25:53)
at /home/runner/work/react-native/react-native/node_modules/danger/distribution/platforms/GitHub.js:19:71
at new Promise (<anonymous>)
at __awaiter (/home/runner/work/react-native/react-native/node_modules/danger/distribution/platforms/GitHub.js:15:12)
at Object.executeRuntimeEnvironment (/home/runner/work/react-native/react-native/node_modules/danger/distribution/platforms/GitHub.js:144:88)
at /home/runner/work/react-native/react-native/node_modules/danger/distribution/commands/danger-runner.js:101:47
at step (/home/runner/work/react-native/react-native/node_modules/danger/distribution/commands/danger-runner.js:34:23)
at Object.next (/home/runner/work/react-native/react-native/node_modules/danger/distribution/commands/danger-runner.js:15:53)
at fulfilled (/home/runner/work/react-native/react-native/node_modules/danger/distribution/commands/danger-runner.js:6:58)
at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
Dangerfile
43| 'This will require a manual import by a Facebook employee.';
44| warn(`${title} - <i>${idea}</i>`);
45| }
46|
47| // Provides advice if a test plan is missing.
--------------------^
48| const includesTestPlan =
49| danger.github.pr.body &&
50| danger.github.pr.body.toLowerCase().includes('## test plan');
51| if (!includesTestPlan && !isFromPhabricator) {
Generated by :no_entry_sign: dangerJS against 2f9efc513d49db02a414aa3d0532e3348b49fa05
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!
This PR is stale because it has been open for 180 days with no activity. It will be closed in 7 days unless you comment on it or remove the "Stale" label.