react-native icon indicating copy to clipboard operation
react-native copied to clipboard

Fix crash that happens with shadow color with 0 alpha

Open joevilches opened this issue 1 year ago • 4 comments

Summary: We crash if we pass a shadow color with 0 alpha due to some divide by 0 logic. This fixes that for inset and outset shadows and adds a test for that case.

Changelog: [Internal]

Differential Revision: D62899047

joevilches avatar Sep 17 '24 21:09 joevilches

This pull request was exported from Phabricator. Differential Revision: D62899047

facebook-github-bot avatar Sep 17 '24 21:09 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D62899047

facebook-github-bot avatar Sep 17 '24 21:09 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D62899047

facebook-github-bot avatar Sep 17 '24 21:09 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D62899047

facebook-github-bot avatar Sep 17 '24 23:09 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D62899047

facebook-github-bot avatar Sep 18 '24 19:09 facebook-github-bot

This pull request has been merged in facebook/react-native@7e38cf32eb76d91e056a56faa57b511dcdbe8129.

facebook-github-bot avatar Sep 18 '24 23:09 facebook-github-bot

This pull request was successfully merged by @joevilches in 7e38cf32eb76d91e056a56faa57b511dcdbe8129

When will my fix make it into a release? | How to file a pick request?

react-native-bot avatar Sep 18 '24 23:09 react-native-bot