react-native icon indicating copy to clipboard operation
react-native copied to clipboard

Using absolute positioning, when the parent element has padding, the width height of the current element is incorrectly laid out using a percentage layout

Open ShaoGongBra opened this issue 1 year ago • 12 comments

Description

/**
 * Sample React Native App
 * https://github.com/facebook/react-native
 *
 * @format
 */

import React from 'react';
import {
  SafeAreaView,
  ScrollView,
  StatusBar,
  useColorScheme,
  View,
} from 'react-native';

function App(): React.JSX.Element {
  const isDarkMode = useColorScheme() === 'dark';

  const backgroundStyle = {
    backgroundColor: '#eee',
  };

  return (
    <SafeAreaView style={backgroundStyle}>
      <StatusBar
        barStyle={isDarkMode ? 'light-content' : 'dark-content'}
        backgroundColor={backgroundStyle.backgroundColor}
      />
      <ScrollView>
        <View
          style={{
            backgroundColor: '#000',
            height: 300,
            paddingTop: 200,
            paddingLeft: 200
          }}>
          <View style={{
            position: 'absolute',
            // width height 100%会排除父元素的padding
            width: '100%', height: '100%', left: 0, top: 0,
            backgroundColor: '#666'
          }} />
        </View>
      </ScrollView>
    </SafeAreaView>
  );
}

export default App;

WX20240909-101807

In the new architecture, I set the height to 100%, but its height is not equal to the height of the parent container, but will subtract the padding of the parent container

Steps to reproduce

1

React Native Version

0.75.2

Affected Platforms

Runtime - Android, Runtime - iOS

Areas

Fabric - The New Renderer

Output of npx react-native info

System:
  OS: macOS 14.5
  CPU: (16) x64 Intel(R) Core(TM) i7-10700 CPU @ 2.90GHz
  Memory: 35.26 MB / 32.00 GB
  Shell:
    version: "5.9"
    path: /bin/zsh
Binaries:
  Node:
    version: 18.20.3
    path: /private/var/folders/rf/gd60z12164z72bny7z_0d4f80000gn/T/xfs-de932bea/node
  Yarn:
    version: 3.6.4
    path: /private/var/folders/rf/gd60z12164z72bny7z_0d4f80000gn/T/xfs-de932bea/yarn
  npm:
    version: 10.7.0
    path: ~/.nvm/versions/node/v18.20.3/bin/npm
  Watchman:
    version: 2024.07.15.00
    path: /usr/local/bin/watchman
Managers:
  CocoaPods:
    version: 1.15.2
    path: /usr/local/bin/pod
SDKs:
  iOS SDK:
    Platforms:
      - DriverKit 23.5
      - iOS 17.5
      - macOS 14.5
      - tvOS 17.5
      - visionOS 1.2
      - watchOS 10.5
  Android SDK: Not Found
IDEs:
  Android Studio: 2024.1 AI-241.18034.62.2412.12266719
  Xcode:
    version: 15.4/15F31d
    path: /usr/bin/xcodebuild
Languages:
  Java:
    version: 17.0.11
    path: /usr/bin/javac
  Ruby:
    version: 2.6.10
    path: /usr/bin/ruby
npmPackages:
  "@react-native-community/cli": Not Found
  react:
    installed: 18.3.1
    wanted: 18.3.1
  react-native:
    installed: 0.75.1
    wanted: 0.75.1
  react-native-macos: Not Found
npmGlobalPackages:
  "*react-native*": Not Found
Android:
  hermesEnabled: true
  newArchEnabled: true
iOS:
  hermesEnabled: Not found
  newArchEnabled: false

Stacktrace or Logs

empty

Reproducer

https://github.com/ShaoGongBra/rn-test

Screenshots and Videos

No response

ShaoGongBra avatar Sep 09 '24 02:09 ShaoGongBra

:warning: Missing Reproducible Example
:information_source: We could not detect a reproducible example in your issue report. Please provide either:
  • If your bug is UI related: a Snack
  • If your bug is build/update related: use our Reproducer Template. A reproducer needs to be in a GitHub repository under your username.

react-native-bot avatar Sep 09 '24 02:09 react-native-bot

:warning: Missing Reproducible Example
:information_source: We could not detect a reproducible example in your issue report. Please provide either:

react-native-bot avatar Sep 09 '24 02:09 react-native-bot

WX20240909-103256 The same code appears inconsistent on the web side and can occupy all the width and height of the parent element

ShaoGongBra avatar Sep 09 '24 02:09 ShaoGongBra

I just closed the new architecture with 0.75.2 and got the same result, which cannot occupy all the height. However, in the previous version, I used 0.71, which was consistent with web performance at that time

ShaoGongBra avatar Sep 09 '24 02:09 ShaoGongBra

hello i think i can solve this issue but i an new to opensource. Can i start forking this project?

krishnendu-2003 avatar Sep 09 '24 17:09 krishnendu-2003

hello i think i can solve this issue but i an new to opensource. Can i start forking this project?

yes

ShaoGongBra avatar Sep 09 '24 17:09 ShaoGongBra

Can you guide me through the file structure of this project? In this directory will i find the app.js file and its other pages?

krishnendu-2003 avatar Sep 09 '24 17:09 krishnendu-2003

Uploading Screenshot 2024-09-09 at 11.16.59 PM.png…

krishnendu-2003 avatar Sep 09 '24 17:09 krishnendu-2003

is it available inside the helloworld directory?

krishnendu-2003 avatar Sep 09 '24 18:09 krishnendu-2003

is it available inside the helloworld directory? The reproduced code is just these two sentences

<View
          style={{
            backgroundColor: '#000',
            height: 300,
            paddingTop: 200,
            paddingLeft: 200
          }}>
          <View style={{
            position: 'absolute',
            // width height 100%会排除父元素的padding
            width: '100%', height: '100%', left: 0, top: 0,
            backgroundColor: '#666'
          }} />
        </View>

ShaoGongBra avatar Sep 10 '24 01:09 ShaoGongBra

@ShaoGongBra this doesn't look New Architecture related (at least from your reproducer), right? Like the same behavior happens on both Old and New Architecture

cortinico avatar Sep 11 '24 17:09 cortinico

这看起来与 New Architecture 无关(至少从您的复制器来看),对吧?就像旧架构和新架构上都会发生相同的行为一样

yes

ShaoGongBra avatar Sep 11 '24 17:09 ShaoGongBra

I just ran into this issue. The only work around is to wrap all content inside the container with another view and set the padding on that one.

<View style={{ backgroundColor: '#000', height: 300 }}>
  <View style={{ position: 'absolute', backgroundColor: '#666', width: '100%', height: '100%' }} />

  <View style={{ paddingTop: 200, paddingLeft: 200 }}>
    {/* your content here */}
  </View>
</View>

Rc85 avatar Nov 20 '24 11:11 Rc85