react-native icon indicating copy to clipboard operation
react-native copied to clipboard

Pass unflattened styles to reconciler

Open javache opened this issue 1 year ago • 3 comments

Summary: When React diffs props, it can can short-circuit nested objects if their object identity hasn't changed. Whenever we use flattenStyle we prevent this optimization from taking place.

Changelog: [Internal]

Differential Revision: D59518281

javache avatar Jul 09 '24 14:07 javache

This pull request was exported from Phabricator. Differential Revision: D59518281

facebook-github-bot avatar Jul 09 '24 14:07 facebook-github-bot

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 21,300,464 -34
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 24,497,477 +8
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: ef2e9410d03215f70277accd2ce4badf3cee6783 Branch: main

analysis-bot avatar Jul 09 '24 14:07 analysis-bot

This pull request was exported from Phabricator. Differential Revision: D59518281

facebook-github-bot avatar Jul 09 '24 17:07 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D59518281

facebook-github-bot avatar Aug 12 '24 13:08 facebook-github-bot

This pull request has been merged in facebook/react-native@d9d638c06bfa55d7562564bb5ae08ecbaf00eee7.

facebook-github-bot avatar Aug 12 '24 15:08 facebook-github-bot

This pull request was successfully merged by @javache in d9d638c06bfa55d7562564bb5ae08ecbaf00eee7

When will my fix make it into a release? | How to file a pick request?

react-native-bot avatar Aug 12 '24 15:08 react-native-bot