react-native icon indicating copy to clipboard operation
react-native copied to clipboard

Feat[iOS]:- added support for titleFontSize,titleFontFamily and titleFontWeight t…

Open Biki-das opened this issue 1 year ago • 6 comments

Summary:

Currently the Refresh Control title styles are limited, i have gotten into cases where i want the title size to be big in specific case, font style to be changed as i want including font weight as well, this PR just extend the same functionality and things seem to be working as i tested the same native code in a react native scaffold

https://github.com/facebook/react-native/assets/72331432/36d12b45-ac56-44f4-9297-8ea0c2238519

Changelog:

[iOS] [Added] - Added Support for Refresh Control titleFontSize,titleFontFamily, titleFontWeight

Test Plan:

Tested in a react native scaffold app

Biki-das avatar Jul 04 '24 12:07 Biki-das

cc @cipolleschi

Biki-das avatar Jul 04 '24 12:07 Biki-das

i definately need a hand solving the flow issues, the androidNativeComponent is complaining even though i have selectively extend the iOS prop types

Biki-das avatar Jul 04 '24 13:07 Biki-das

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 21,285,090 -22
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 24,481,869 +10
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 261f82e897d34196d743d8f81bcae7fd79831643 Branch: main

analysis-bot avatar Jul 04 '24 13:07 analysis-bot

There are a lot of failures in CI and the code only tackles the Old Architecture. Could you have a look at them and also implement the same changes in the New Architecture, please? 🙏

cipolleschi avatar Jul 09 '24 10:07 cipolleschi

yes the Ci fails are mostly flow related, also where is the new arch code, could you just hint me up to the same? is there any additional config to get the new arch code

Biki-das avatar Jul 09 '24 10:07 Biki-das

New arch code should be here.

In general, if there is Fabric or react/renderer/component in the path, you are working on a New Arch file.

To test it, on iOS, just run RCT_NEW_ARCH_ENABLED=1 bundle exec pod install when you install your dependencies.

cipolleschi avatar Jul 09 '24 12:07 cipolleschi

This PR is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days.

react-native-bot avatar Aug 14 '25 05:08 react-native-bot

This PR was closed because it has been stalled for 7 days with no activity.

react-native-bot avatar Aug 22 '25 05:08 react-native-bot