react-native icon indicating copy to clipboard operation
react-native copied to clipboard

Error should not be printed when parent scrollEnabled is FALSE.

Open heddaz opened this issue 1 year ago • 2 comments

Summary:

VirtualizedLists should never be nested inside plain ScrollViews with the same orientation because it can break windowing and other functionality - use another VirtualizedList-backed container instead. Above error is being printed even though the only one scroll is enabled.

Changelog:

Adding a check on scrollContext to correctly bypass the error.

Test Plan:

Currently no.

heddaz avatar Jul 03 '24 07:07 heddaz

Hi @HeddaZ!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

facebook-github-bot avatar Jul 03 '24 07:07 facebook-github-bot

Fails
:no_entry_sign:

:clipboard: Verify Changelog Format - See Changelog format

Generated by :no_entry_sign: dangerJS against 5b04c6a83cdf1d073719854778b1c3d996fc212e

github-actions[bot] avatar Jul 03 '24 07:07 github-actions[bot]

This PR is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days.

react-native-bot avatar Aug 14 '25 05:08 react-native-bot

This PR was closed because it has been stalled for 7 days with no activity.

react-native-bot avatar Aug 22 '25 05:08 react-native-bot