react-native icon indicating copy to clipboard operation
react-native copied to clipboard

Make DefaultComponentsRegistry the default behaviour for ComponentFactory

Open javache opened this issue 1 year ago • 2 comments

Summary: Merge newarchdefaults jni target into fabric and turbomodule targets. These do not need to be their own shared library, and allows us to simplify things further, like making ComponentFactory default to using the CoreComponentsRegistry + registerComponentDescriptorsFromEntryPoint.

Changelog: [Android][Removed] DefaultsComponentRegistry.register is now a no-op, please remove calls to it.

Differential Revision: D59269549

javache avatar Jul 02 '24 10:07 javache

This pull request was exported from Phabricator. Differential Revision: D59269549

facebook-github-bot avatar Jul 02 '24 10:07 facebook-github-bot

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 20,202,072 -98,493
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 23,398,877 -98,496
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: ad3df84668f1624e830396364c331783c6f99948 Branch: main

analysis-bot avatar Jul 02 '24 10:07 analysis-bot

This PR is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days.

react-native-bot avatar Aug 14 '25 05:08 react-native-bot

This PR was closed because it has been stalled for 7 days with no activity.

react-native-bot avatar Aug 22 '25 05:08 react-native-bot