react-native icon indicating copy to clipboard operation
react-native copied to clipboard

Set up experiment to fix incorrect state updates in smooth scroll animations on Android

Open rubennorte opened this issue 1 year ago • 3 comments

Summary: Changelog: [internal]

This creates a feature flag to test a fix for an incorrect state update dispatched to Fabric when using smooth scroll animations.

Specifically, when starting a smooth scroll animation from X to Y, the scroll view would set the state to Y, and then all the range from X to Y again. For example, the sequence of state updates when smooth scrolling from 0 to 5 would be 0 -> 5 -> 1 -> 2 -> 3 -> 4 -> 5, which is obviously incorrect.

This flag prevents setting the final value before it's actually reached.

Differential Revision: D59233069

rubennorte avatar Jul 01 '24 18:07 rubennorte

This pull request was exported from Phabricator. Differential Revision: D59233069

facebook-github-bot avatar Jul 01 '24 18:07 facebook-github-bot

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 20,300,842 +272
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 23,497,431 +70
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: ffd0b39755af3c096df5329a367d5a708a015a48 Branch: main

analysis-bot avatar Jul 01 '24 19:07 analysis-bot

This pull request was exported from Phabricator. Differential Revision: D59233069

facebook-github-bot avatar Jul 02 '24 11:07 facebook-github-bot

This pull request has been merged in facebook/react-native@e35a2f4a7c58905f1d2b60720b91cc1daa8c0194.

facebook-github-bot avatar Jul 02 '24 15:07 facebook-github-bot