react-native icon indicating copy to clipboard operation
react-native copied to clipboard

fix: ensure `--build-output` destination exists

Open szymonrybczak opened this issue 1 year ago • 1 comments

Summary:

Replicates https://github.com/react-native-community/cli/commit/48d4c29bba4e8b16cbc8307bd1b4c5349f3651d8, which landed inside cli-plugin-metro inside RNC CLI, but because of migration of code to community-cli-plugin it looks like apparently the fix wasn't replicated.

Changelog:

[GENERAL] [FIXED] - Ensure --build-output destination exists

Test Plan:

Specify a new directory that doesn't exists inside --build-output:

npx react-native bundle --build-output dist/new-dir/index.bundle

and this command shouldn't fail.

szymonrybczak avatar Jun 26 '24 11:06 szymonrybczak

cc @tido64 just FYI

szymonrybczak avatar Jun 26 '24 11:06 szymonrybczak

@huntie has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar Aug 27 '24 13:08 facebook-github-bot

@huntie merged this pull request in facebook/react-native@396bdd87d8021902ad78b817314fdc5b6207c2ea.

facebook-github-bot avatar Aug 27 '24 16:08 facebook-github-bot

This pull request was successfully merged by @szymonrybczak in 396bdd87d8021902ad78b817314fdc5b6207c2ea

When will my fix make it into a release? | How to file a pick request?

react-native-bot avatar Aug 27 '24 16:08 react-native-bot