react-native icon indicating copy to clipboard operation
react-native copied to clipboard

stop sending State in view preallocation on Android

Open sammy-SC opened this issue 1 year ago • 3 comments

Summary: changelog: [internal]

state object is usually invalid when first constructed and with view preallocation, it remains unused. This is unnecessary work that we can avoid by simply not sending state through jni during view preallocation.

Differential Revision: D58529357

sammy-SC avatar Jun 14 '24 17:06 sammy-SC

This pull request was exported from Phabricator. Differential Revision: D58529357

facebook-github-bot avatar Jun 14 '24 17:06 facebook-github-bot

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 21,300,376 -446
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 24,497,455 -122
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 5b03453b5f01a0fa7e3f1ee1f74a7e215e38cddd Branch: main

analysis-bot avatar Jun 14 '24 18:06 analysis-bot

This pull request was exported from Phabricator. Differential Revision: D58529357

facebook-github-bot avatar Jul 09 '24 14:07 facebook-github-bot

This PR is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days.

react-native-bot avatar Aug 14 '25 05:08 react-native-bot

This PR was closed because it has been stalled for 7 days with no activity.

react-native-bot avatar Aug 21 '25 05:08 react-native-bot