react-native icon indicating copy to clipboard operation
react-native copied to clipboard

Mark IntBufferBatchMountItem as nullsafe

Open NickGerleman opened this issue 1 year ago • 3 comments

Summary: Noticed when running arc nn

Advice xplat/js/react-native-github/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/fabric/mounting/mountitems/IntBufferBatchMountItem.java:39 [Class has 0 issues and can be marked Nullsafe] Congrats! IntBufferBatchMountItem is free of nullability issues. Mark it Nullsafe(Nullsafe.Mode.LOCAL) to prevent regressions.

Changelog: [Internal]

Differential Revision: D57249958

NickGerleman avatar May 11 '24 23:05 NickGerleman

This pull request was exported from Phabricator. Differential Revision: D57249958

facebook-github-bot avatar May 11 '24 23:05 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D57249958

facebook-github-bot avatar May 11 '24 23:05 facebook-github-bot

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 19,558,986 +350
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 22,928,816 +54
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 3f17c8b5f04cd80517d7ba3943745f37dce7f5dd Branch: main

analysis-bot avatar May 11 '24 23:05 analysis-bot

This pull request has been merged in facebook/react-native@2cc3ba1f19739baa866bd11c2c4e80d2100219d0.

facebook-github-bot avatar May 14 '24 07:05 facebook-github-bot

This pull request was successfully merged by @NickGerleman in 2cc3ba1f19739baa866bd11c2c4e80d2100219d0.

When will my fix make it into a release? | How to file a pick request?

github-actions[bot] avatar May 14 '24 07:05 github-actions[bot]