react-native icon indicating copy to clipboard operation
react-native copied to clipboard

Add BindingsInstaller for TurboModules on Android

Open Kudo opened this issue 1 year ago • 2 comments

Summary:

Add synchronous JS bindings installation for TurboModules. That would help some 3rd party JSI based modules to install JS bindings easier. #44486 for Android

Changelog:

[Android] [ADDED] - Add BindingsInstaller for TurboModules

Test Plan:

Added test in RN-Tester TurboModule test case

Kudo avatar May 10 '24 16:05 Kudo

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 19,528,339 -12,836
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 22,900,398 -11,631
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 26fc40d0f7a9c5a4880d97b8853350872f1890f0 Branch: main

analysis-bot avatar May 10 '24 16:05 analysis-bot

@philIip has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar May 10 '24 19:05 facebook-github-bot

@philIip merged this pull request in facebook/react-native@d999e9bf1ee6cad513be38c4f2c795ab58f59aa4.

facebook-github-bot avatar May 31 '24 03:05 facebook-github-bot

This pull request was successfully merged by @Kudo in d999e9bf1ee6cad513be38c4f2c795ab58f59aa4.

When will my fix make it into a release? | How to file a pick request?

github-actions[bot] avatar May 31 '24 03:05 github-actions[bot]