react-native icon indicating copy to clipboard operation
react-native copied to clipboard

Migration RN Alert Dialog to androidx

Open Abbondanzo opened this issue 1 year ago • 7 comments

Summary

Migrates the AlertFragment from android.app.AlertDialog to androidx.appcompat.app.AlertDialog. This backports tons of fixes that have gone into the AlertDialog component over the years, including proper line wrapping of button text, dark mode support, alignment of buttons, etc.

This change provides a fallback to the original android.app.AlertDialog if the current activity is not an AppCompat descendant.

For consideration

  • Alert dialog themes may no longer need the android namespace, meaning themes can now be specified as alertDialogTheme rather than android:alertDialogTheme.

Changelog:

[Android] [Changed] - Migrated AlertDialog to androidx.appcompat

Differential Revision: D57019423 and D57113950

Abbondanzo avatar May 08 '24 17:05 Abbondanzo

This pull request was exported from Phabricator. Differential Revision: D57113950

facebook-github-bot avatar May 08 '24 17:05 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D57113950

facebook-github-bot avatar May 08 '24 17:05 facebook-github-bot

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 20,249,243 -5
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 23,454,742 -8
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 8a15e0d97ad7556b9f1b4068662791a32e1ae3d2 Branch: main

analysis-bot avatar May 08 '24 18:05 analysis-bot

This pull request was exported from Phabricator. Differential Revision: D57113950

facebook-github-bot avatar May 09 '24 15:05 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D57113950

facebook-github-bot avatar May 10 '24 16:05 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D57113950

facebook-github-bot avatar May 10 '24 18:05 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D57113950

facebook-github-bot avatar May 13 '24 20:05 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D57113950

facebook-github-bot avatar May 23 '24 13:05 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D57113950

facebook-github-bot avatar Jun 06 '24 15:06 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D57113950

facebook-github-bot avatar Jun 10 '24 16:06 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D57113950

facebook-github-bot avatar Jun 10 '24 20:06 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D57113950

facebook-github-bot avatar Jun 11 '24 13:06 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D57113950

facebook-github-bot avatar Jun 11 '24 21:06 facebook-github-bot

This pull request has been merged in facebook/react-native@297ded90aa1e905a37dba316e7b19b6779c8c804.

facebook-github-bot avatar Jun 12 '24 18:06 facebook-github-bot