react-native icon indicating copy to clipboard operation
react-native copied to clipboard

introduce CallInvokerHolder stable API

Open philIip opened this issue 1 year ago • 1 comments

Summary: Changelog: [Android][Added]

I am adding this API in favor of RCTRuntimeExecutor. CallInvoker is now preferred because after #43375, the CallInvoker has access to the jsi::Runtime. Since the community is using CallInvoker already for their async access use cases, CallInvoker is the preferred choice of RuntimeExecutor / RuntimeScheduler because of easier migration. Also, having a wrapper like CallInvoker will give us more flexibility in the future if we want to expand this API.

this will be forward compatible in the old architecture

Differential Revision: D56866817

philIip avatar May 02 '24 04:05 philIip

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 19,511,391 -2
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 22,883,944 -9
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 05a4232dd591e2d43f192d69ca14a04f4a3fb6a1 Branch: main

analysis-bot avatar May 02 '24 04:05 analysis-bot

This pull request was exported from Phabricator. Differential Revision: D56866817

facebook-github-bot avatar May 03 '24 04:05 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D56866817

facebook-github-bot avatar May 03 '24 05:05 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D56866817

facebook-github-bot avatar May 03 '24 05:05 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D56866817

facebook-github-bot avatar May 04 '24 03:05 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D56866817

facebook-github-bot avatar May 04 '24 03:05 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D56866817

facebook-github-bot avatar May 04 '24 03:05 facebook-github-bot

This pull request has been merged in facebook/react-native@69bb4fca44c4a6c094b6c4c5c03a7e9aefa7ed1f.

facebook-github-bot avatar May 04 '24 09:05 facebook-github-bot

This pull request was successfully merged by @philIip in 69bb4fca44c4a6c094b6c4c5c03a7e9aefa7ed1f.

When will my fix make it into a release? | How to file a pick request?

github-actions[bot] avatar May 04 '24 09:05 github-actions[bot]