react-native icon indicating copy to clipboard operation
react-native copied to clipboard

Improve spec-compliance of bridgeless timer implementation

Open javache opened this issue 1 year ago • 3 comments

Summary:

  • setInterval's second argument is optional, and defaults to 0
  • setTimeout is spec'ed to return a positive integer.

There's also no need to use HostObjects here to represent the timer index, it just hurts performance and makes this code more complex for no clear reason.

Changelog: [General][Fixed] New architecture timer methods now return integers instead of an opaque object.

Differential Revision: D56863422

javache avatar May 02 '24 03:05 javache

This pull request was exported from Phabricator. Differential Revision: D56863422

facebook-github-bot avatar May 02 '24 03:05 facebook-github-bot

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 19,511,401 -16,384
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 22,883,928 -16,419
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: eb1b42fa8b2834bebb9eb5b31201e6c20ae575fe Branch: main

analysis-bot avatar May 02 '24 03:05 analysis-bot

This pull request was exported from Phabricator. Differential Revision: D56863422

facebook-github-bot avatar May 02 '24 05:05 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D56863422

facebook-github-bot avatar May 02 '24 20:05 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D56863422

facebook-github-bot avatar May 03 '24 04:05 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D56863422

facebook-github-bot avatar May 03 '24 05:05 facebook-github-bot

This pull request has been merged in facebook/react-native@a16f7dc547e85daed7e3732142f36cce5699faa0.

facebook-github-bot avatar May 03 '24 15:05 facebook-github-bot

This pull request was successfully merged by @javache in a16f7dc547e85daed7e3732142f36cce5699faa0.

When will my fix make it into a release? | How to file a pick request?

github-actions[bot] avatar May 03 '24 15:05 github-actions[bot]