react-native
react-native copied to clipboard
Improve spec-compliance of bridgeless timer implementation
Summary:
- setInterval's second argument is optional, and defaults to 0
- setTimeout is spec'ed to return a positive integer.
There's also no need to use HostObjects here to represent the timer index, it just hurts performance and makes this code more complex for no clear reason.
Changelog: [General][Fixed] New architecture timer methods now return integers instead of an opaque object.
Differential Revision: D56863422
This pull request was exported from Phabricator. Differential Revision: D56863422
| Platform | Engine | Arch | Size (bytes) | Diff |
|---|---|---|---|---|
| android | hermes | arm64-v8a | 19,511,401 | -16,384 |
| android | hermes | armeabi-v7a | n/a | -- |
| android | hermes | x86 | n/a | -- |
| android | hermes | x86_64 | n/a | -- |
| android | jsc | arm64-v8a | 22,883,928 | -16,419 |
| android | jsc | armeabi-v7a | n/a | -- |
| android | jsc | x86 | n/a | -- |
| android | jsc | x86_64 | n/a | -- |
Base commit: eb1b42fa8b2834bebb9eb5b31201e6c20ae575fe Branch: main
This pull request was exported from Phabricator. Differential Revision: D56863422
This pull request was exported from Phabricator. Differential Revision: D56863422
This pull request was exported from Phabricator. Differential Revision: D56863422
This pull request was exported from Phabricator. Differential Revision: D56863422
This pull request has been merged in facebook/react-native@a16f7dc547e85daed7e3732142f36cce5699faa0.
This pull request was successfully merged by @javache in a16f7dc547e85daed7e3732142f36cce5699faa0.
When will my fix make it into a release? | How to file a pick request?