react-native
react-native copied to clipboard
facebook
Fix onKeyLongPress() in RELEASE
Summary:
In RELEASE mode, the devSupportManager received is ReleaseDevSupportManager for which showDevOptionsDialog() is a no-op
https://github.com/facebook/react-native/blob/main/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/devsupport/ReleaseDevSupportManager.java#L66
Which is expected since this is a capability only in Dev mode(useDeveloperSupport = true). However, ATM onKeyLongPresss() returns true in RELEASE as well which is a bug.
Since there is no need for onKeyLongPress() in RELEASE, changing it's logic to introduce that check and return false in case of RELEASE.
Changelog: [Android][Fixed] onKeyLongPress() in RELEASE mode
Differential Revision: D56850466
| Platform | Engine | Arch | Size (bytes) | Diff |
|---|---|---|---|---|
| android | hermes | arm64-v8a | 19,478,538 | -6 |
| android | hermes | armeabi-v7a | n/a | -- |
| android | hermes | x86 | n/a | -- |
| android | hermes | x86_64 | n/a | -- |
| android | jsc | arm64-v8a | 22,851,081 | -6 |
| android | jsc | armeabi-v7a | n/a | -- |
| android | jsc | x86 | n/a | -- |
| android | jsc | x86_64 | n/a | -- |
Base commit: 0383669a4b19289678ed75b28e38a74fabb01a64 Branch: main
