react-native icon indicating copy to clipboard operation
react-native copied to clipboard

Expose BaseJavaModule constructors through ViewManager

Open javache opened this issue 1 year ago • 1 comments

Summary: ViewManagers are all BaseJavaModule, and thus have access to methods like getReactApplicationContext. We don't expose the appropriate constructors though to pass this context down from the base class.

Not a breaking change, as the no-arg constructor is still used implicitly.

Changelog: [Android][Fixed] ViewManagers can pass context to their base class.

Differential Revision: D56804318

javache avatar May 01 '24 14:05 javache

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 19,478,537 +6
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 22,851,046 +9
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: d77f80696037b9c87a576d9e1150829b7c867870 Branch: main

analysis-bot avatar May 01 '24 14:05 analysis-bot

Merged as https://github.com/facebook/react-native/commit/90663081de872243203da99116d2cab0fbec95ff

javache avatar Jun 27 '24 20:06 javache