react-native
react-native copied to clipboard
Fix getDevSupportManager() in ReactDelegate
Summary:
In https://github.com/facebook/react-native/pull/43520, this was moved to supply with the relevant DevSupportManager, however this check for useDeveloperSupport is already part of https://github.com/facebook/react-native/blob/0.74-stable/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/ReactInstanceManager.java#L263
https://github.com/facebook/react-native/blob/0.74-stable/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/devsupport/DefaultDevSupportManagerFactory.java#L68-L70
Having this check here was causing early exit for Bridge RELEASE mode instead of returning the ReleaseDevSupportManager.
Changelog:
[ANDROID][FIXED] - Fixed getDevSupportManager() in ReactDelegate
Reviewed By: javache
Differential Revision: D56739764
| Platform | Engine | Arch | Size (bytes) | Diff |
|---|---|---|---|---|
| android | hermes | arm64-v8a | 19,445,759 | +2 |
| android | hermes | armeabi-v7a | n/a | -- |
| android | hermes | x86 | n/a | -- |
| android | hermes | x86_64 | n/a | -- |
| android | jsc | arm64-v8a | 22,818,292 | +1 |
| android | jsc | armeabi-v7a | n/a | -- |
| android | jsc | x86 | n/a | -- |
| android | jsc | x86_64 | n/a | -- |
Base commit: c96c8933745b72148856e62f13553d7a2f5d4f6b Branch: main
Closed internally