react-native
react-native copied to clipboard
yarn run build output
Summary:
We require the wrapper code for in repository calls to these packages directly from node (i.e. using CommonJS). This wrapper code typically sits at the entrypoint of the build packages (i.e. index.js).
Problem:
The flow-api-translator library doesn't allow CommonJS module.exports when generating TypeScript Type Defintions.
Change
- At the built time, this strips out our wrapper code and sets up the dist/ folder appropriately for npm distribution.
- Updated the
package.jsonfiles to consistently share Flow types
Changelog: [Internal] refactor build packages output to remove wrapper.
Differential Revision: D56762162
| Platform | Engine | Arch | Size (bytes) | Diff |
|---|---|---|---|---|
| android | hermes | arm64-v8a | 19,478,550 | -3 |
| android | hermes | armeabi-v7a | n/a | -- |
| android | hermes | x86 | n/a | -- |
| android | hermes | x86_64 | n/a | -- |
| android | jsc | arm64-v8a | 22,851,070 | +10 |
| android | jsc | armeabi-v7a | n/a | -- |
| android | jsc | x86 | n/a | -- |
| android | jsc | x86_64 | n/a | -- |
Base commit: 90663081de872243203da99116d2cab0fbec95ff Branch: main
This pull request was exported from Phabricator. Differential Revision: D56762162
This pull request has been merged in facebook/react-native@b38f80aeb6ad986c64fd03f53b2e01a7990e1533.
This pull request was successfully merged by @blakef in b38f80aeb6ad986c64fd03f53b2e01a7990e1533.
When will my fix make it into a release? | How to file a pick request?