react-native icon indicating copy to clipboard operation
react-native copied to clipboard

Published 20 hours ago • verified publisher icon facebook

Add test for LazyShadowTreeRevisionConsistencyManager and fix bugs

Open rubennorte opened this issue 1 year ago • 1 comments

Summary: Changelog: [internal]

LazyShadowTreeRevisionConsistencyManager wasn't correctly updating the locked revision, because emplace is a no-op if there's already a value for the key in the unordered_map.

This fixes the issue and adds tests that actually showed it.

Reviewed By: sammy-SC

Differential Revision: D56761941

rubennorte avatar Apr 30 '24 15:04 rubennorte

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 19,429,403 +10
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 22,801,917 -1
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 44e78ff74a541b3462a0b311d6fefd3ee7870263 Branch: main

analysis-bot avatar Apr 30 '24 16:04 analysis-bot

Merged as https://github.com/facebook/react-native/commit/cfbee0b7ec3449b22be0d8dd9e68b245a4fc68da

javache avatar Jun 27 '24 21:06 javache