react-native
react-native copied to clipboard
facebook
Fix `react` peer dependency to support `react` v18.3
Summary:
This PR updates the peer dependency for React to support version 18.3. The motivation for this change stems from an issue where installing React 18.3 alongside React Native results in npm errors due to strict peer dependency enforcement. This was causing npm to throw errors because the existing configuration did not support React 18.3.
Changelog:
[GENERAL] [CHANGED] - Update react peer dependency to include support for react v18.3 to resolve npm strict peer dependency errors.
Test Plan:
Since the release of React 18.3 does not introduce breaking changes but adds warnings for deprecated APIs to prepare for React 19, no new specific tests were added for this update. Please let me know if I need to change anything.
Hi @aryaemami59!
Thank you for your pull request and welcome to our community.
Action Required
In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.
Process
In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.
Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.
If you have received this in error or have any questions, please contact us at [email protected]. Thanks!
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!
| Platform | Engine | Arch | Size (bytes) | Diff |
|---|---|---|---|---|
| android | hermes | arm64-v8a | 20,317,006 | -9 |
| android | hermes | armeabi-v7a | n/a | -- |
| android | hermes | x86 | n/a | -- |
| android | hermes | x86_64 | n/a | -- |
| android | jsc | arm64-v8a | 23,513,651 | +6 |
| android | jsc | armeabi-v7a | n/a | -- |
| android | jsc | x86 | n/a | -- |
| android | jsc | x86_64 | n/a | -- |
Base commit: 1a990d19043e46ad038fa0e3641238938092488b Branch: main
What's the ETA on a release with this fix? 18.3 is functionally the same as 18.2, but with deprecation warnings. This should be an easy upgrade.
Can someone explain to me what's going on here? When will this be in a public release?
@aryaemami59 is this some weird internal branch you keep rebasing from?
This was fixed in React 0.75.2. https://github.com/facebook/react-native/commit/011118fe13f3276bd5f5473cd8c6d403f28aa887