react-native Remove unnecessary std::function indirection in console

Remove unnecessary std::function indirection in console

Open motiz88 opened this issue 1 year ago • 1 comments

Summary: Changelog: [Internal]

Switches to constrained auto instead of std::function to represent intermediate function types in RuntimeTargetConsole::installConsoleHandler. This removes some indirection and potential runtime overhead.

Differential Revision: D56675188

Apr 28 '24 10:04 motiz88

Platform Engine Arch Size (bytes) Diff

android hermes arm64-v8a 19,477,716 +32,772

android hermes armeabi-v7a n/a --

android hermes x86 n/a --

android hermes x86_64 n/a --

android jsc arm64-v8a 22,850,632 +32,771

android jsc armeabi-v7a n/a --

android jsc x86 n/a --

android jsc x86_64 n/a --

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	19,477,716	+32,772
android	hermes	armeabi-v7a	n/a	--
android	hermes	x86	n/a	--
android	hermes	x86_64	n/a	--
android	jsc	arm64-v8a	22,850,632	+32,771
android	jsc	armeabi-v7a	n/a	--
android	jsc	x86	n/a	--
android	jsc	x86_64	n/a	--

Base commit: bb120ff663ae56ca825b7b32873127ea91d52720 Branch: main

Apr 28 '24 11:04 analysis-bot

Merged as https://github.com/facebook/react-native/commit/38f8b8e099d94a864b822f5b2d79bfe3f3f84bc6

Jun 27 '24 20:06 javache

react-native react-native copied to clipboard

Remove unnecessary std::function indirection in console

react-native
react-native copied to clipboard