react-native
react-native copied to clipboard
Update ColorPropConverterto support color function values (#43031)
Summary: This adds support for color function values to ColorPropConverter per the wide gamut color RFC. It updates the color conversion code so that it returns a Color instance before ultimately being converted to an Integer in preparation for returning long values as needed.
Changelog:
[ANDROID] [ADDED] - Update ColorPropConverter to support color function values
Test Plan:
Colors should work exactly the same as before.
Follow test steps from https://github.com/facebook/react-native/pull/42831 to test support for color() function syntax.
While colors specified with color() function syntax will not yet render in DisplayP3 color space they will not be misrecognized as resource path colors but will instead fallback to their sRGB color space values.
After the failure with the tests, I reapplied the changes and test some Jest e2e tests that were failing yesterday:
{F1495277376}
Differential Revision: D56517579
Pulled By: cipolleschi
This pull request was exported from Phabricator. Differential Revision: D56517579
This pull request was exported from Phabricator. Differential Revision: D56517579
| Platform | Engine | Arch | Size (bytes) | Diff |
|---|---|---|---|---|
| android | hermes | arm64-v8a | 19,542,763 | +8 |
| android | hermes | armeabi-v7a | n/a | -- |
| android | hermes | x86 | n/a | -- |
| android | hermes | x86_64 | n/a | -- |
| android | jsc | arm64-v8a | 22,912,797 | +3 |
| android | jsc | armeabi-v7a | n/a | -- |
| android | jsc | x86 | n/a | -- |
| android | jsc | x86_64 | n/a | -- |
Base commit: 99704800a13136510562f197bcb54d603a7c35a5 Branch: main
This pull request was exported from Phabricator. Differential Revision: D56517579
@cipolleschi merged this pull request in facebook/react-native@4fb5573796e33868aefe4ebdcb8250e171af4989.
This pull request was successfully merged by @ryanlntn in 4fb5573796e33868aefe4ebdcb8250e171af4989.
When will my fix make it into a release? | How to file a pick request?