react-native icon indicating copy to clipboard operation
react-native copied to clipboard

clean up interfaces for view preallocation

Open sammy-SC opened this issue 1 year ago • 2 comments

Summary: changelog: [internal]

surfaceId parameter is not needed schedulerDidRequestPreliminaryViewAllocation as it can be derived from shadow node. Additionally, conversion to ShadowView can happen on the lower layers.

Reviewed By: NickGerleman

Differential Revision: D56350599

sammy-SC avatar Apr 24 '24 09:04 sammy-SC

This pull request was exported from Phabricator. Differential Revision: D56350599

facebook-github-bot avatar Apr 24 '24 09:04 facebook-github-bot

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 19,410,887 -38
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 22,784,325 +6
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: e25860f07c6af8d529d618da3ded556485ca0a73 Branch: main

analysis-bot avatar Apr 24 '24 09:04 analysis-bot

This pull request has been merged in facebook/react-native@0dbe6f10c1e261bc087ea99dbe7aef75e36eb749.

facebook-github-bot avatar Apr 25 '24 11:04 facebook-github-bot

This pull request was successfully merged by @sammy-SC in 0dbe6f10c1e261bc087ea99dbe7aef75e36eb749.

When will my fix make it into a release? | How to file a pick request?

github-actions[bot] avatar Apr 25 '24 11:04 github-actions[bot]