react-native icon indicating copy to clipboard operation
react-native copied to clipboard

Make sure to return a color for API < 26

Open cipolleschi opened this issue 1 year ago • 3 comments

Summary: When landing D55749058, I had to gate some API calls with a version check as those API where not available for Versions < 26.

However, while doing that, I overlooked the fact that we might end up not returning any color and throwing an exception.

This change makes sure that, if the version does not support API 26, we fall back to the previous mechanism.

Changelog:

[Android][Fixed] - Make sure to return a color when APIs version do not support WideGamut

Differential Revision: D56485922

cipolleschi avatar Apr 23 '24 20:04 cipolleschi

This pull request was exported from Phabricator. Differential Revision: D56485922

facebook-github-bot avatar Apr 23 '24 20:04 facebook-github-bot

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 19,410,907 -10
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 22,784,323 -2
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 4928f44f70943f90c9105fccc5f14731073d4666 Branch: main

analysis-bot avatar Apr 23 '24 20:04 analysis-bot

This pull request was exported from Phabricator. Differential Revision: D56485922

facebook-github-bot avatar Apr 23 '24 20:04 facebook-github-bot

abandoned internally

cipolleschi avatar Apr 24 '24 14:04 cipolleschi