react-native icon indicating copy to clipboard operation
react-native copied to clipboard

Published 20 hours ago • verified publisher icon facebook

only trigger RCTContentDidAppearNotification when content appears

Open sammy-SC opened this issue 1 year ago • 1 comments

Summary: changelog: [internal]

Notification RCTContentDidAppearNotification was posted too early in RCTSurfaceHostingProxyRootView, which does not know when views are mounted. It was also posted if no views were mounted, leading to inconsistent behaviour between Paper and Fabric.

The implementation is aligned with Paper: https://github.com/facebook/react-native/blob/main/packages/react-native/React/Base/RCTRootContentView.m#L45-L55

Differential Revision: D55640654

sammy-SC avatar Apr 03 '24 18:04 sammy-SC

This pull request was exported from Phabricator. Differential Revision: D55640654

facebook-github-bot avatar Apr 03 '24 18:04 facebook-github-bot

This pull request has been merged in facebook/react-native@c7d9571d6acbbeea1689934d6036864238eff656.

facebook-github-bot avatar Apr 04 '24 12:04 facebook-github-bot

This pull request was successfully merged by @sammy-SC in c7d9571d6acbbeea1689934d6036864238eff656.

When will my fix make it into a release? | How to file a pick request?

github-actions[bot] avatar Apr 04 '24 12:04 github-actions[bot]