react-native
react-native copied to clipboard
Do not attempt to call `Class.forName` in OSS
Summary: We should not attempt to load generated classes by the Annotation processor in OSS because we simply don't run it, so those classes will fail to load. I'm short-circuiting the logic here.
This is sustainability work as we got a report for this in OSS a while ago and I never got the time to work on it.
Changelog: [Internal] [Changed] - Do not attempt to call Class.forName in OSS
Differential Revision: D55693479
This pull request was exported from Phabricator. Differential Revision: D55693479
| Platform | Engine | Arch | Size (bytes) | Diff |
|---|---|---|---|---|
| android | hermes | arm64-v8a | 18,910,458 | +10 |
| android | hermes | armeabi-v7a | n/a | -- |
| android | hermes | x86 | n/a | -- |
| android | hermes | x86_64 | n/a | -- |
| android | jsc | arm64-v8a | 22,279,111 | +4 |
| android | jsc | armeabi-v7a | n/a | -- |
| android | jsc | x86 | n/a | -- |
| android | jsc | x86_64 | n/a | -- |
Base commit: e1800726af78c7c01a20d13b8dd390ed4aa35c14 Branch: main
This pull request has been merged in facebook/react-native@26cc8cddf98cfefcfa35fba58da08587febdf926.
This pull request was successfully merged by @cortinico in 26cc8cddf98cfefcfa35fba58da08587febdf926.
When will my fix make it into a release? | How to file a pick request?