react-native icon indicating copy to clipboard operation
react-native copied to clipboard

Do not attempt to call `Class.forName` in OSS

Open cortinico opened this issue 1 year ago • 2 comments

Summary: We should not attempt to load generated classes by the Annotation processor in OSS because we simply don't run it, so those classes will fail to load. I'm short-circuiting the logic here.

This is sustainability work as we got a report for this in OSS a while ago and I never got the time to work on it.

Changelog: [Internal] [Changed] - Do not attempt to call Class.forName in OSS

Differential Revision: D55693479

cortinico avatar Apr 03 '24 13:04 cortinico

This pull request was exported from Phabricator. Differential Revision: D55693479

facebook-github-bot avatar Apr 03 '24 13:04 facebook-github-bot

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 18,910,458 +10
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 22,279,111 +4
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: e1800726af78c7c01a20d13b8dd390ed4aa35c14 Branch: main

analysis-bot avatar Apr 03 '24 14:04 analysis-bot

This pull request has been merged in facebook/react-native@26cc8cddf98cfefcfa35fba58da08587febdf926.

facebook-github-bot avatar Apr 04 '24 06:04 facebook-github-bot

This pull request was successfully merged by @cortinico in 26cc8cddf98cfefcfa35fba58da08587febdf926.

When will my fix make it into a release? | How to file a pick request?

github-actions[bot] avatar Apr 04 '24 06:04 github-actions[bot]