react-native icon indicating copy to clipboard operation
react-native copied to clipboard

Suppress soft exceptions in ReactHostImpl when they aren't needed

Open GijsWeterings opened this issue 1 year ago • 1 comments

Summary: D54574139, D54703159 and D54670119 added onNewIntent, onActivityResult and onWindowFocusChange

These methods, like others in this class, check for a context to be ready before passing on a method. However, these two methods don't return anything in the if statement, so they still fall through to the soft exception.

This diff simply adds returns to match the (what I believe to be) specific expecatation

Changelog: [Android][Fixed] - Suppress unneeded soft exceptions in ReactHostImpl when Context has initiated correctly.

Differential Revision: D55635376

GijsWeterings avatar Apr 02 '24 10:04 GijsWeterings

This pull request was exported from Phabricator. Differential Revision: D55635376

facebook-github-bot avatar Apr 02 '24 10:04 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D55635376

facebook-github-bot avatar Apr 04 '24 10:04 facebook-github-bot

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 18,918,800 -5
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 22,283,300 -4
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: bc3e3360d1bd3fde9ab4d28c49757e3db0dad7f9 Branch: main

analysis-bot avatar Apr 04 '24 11:04 analysis-bot